Completion for nushell #450
Conversation
| @@ -0,0 +1,191 @@ | |||
| module pueue_completions { | |||
There was a problem hiding this comment.
Please move this file to a utils/completions/ directory.
The src folder is reserved for rust code and things that're tightly integrated with that code.
the src/bin folder specifically should only contain entry points for binaries.
| // Clap **doesn't** support nushell | ||
| // So I have written a completion script for nushell | ||
| fn generate_nushell_completion(output_directory: &PathBuf) -> std::result::Result<PathBuf, std::io::Error>{ | ||
| let path = output_directory.join("pueue.nu"); | ||
| //It should be in pueue directory | ||
| fs::write(path.clone(), include_bytes!("pueue.nu"))?; | ||
| Ok(path) | ||
|
|
||
| } |
There was a problem hiding this comment.
To be honest, I'm not comfortable with having this in the generate command, since this creates the impression that this script will be auto-generated just like the others.
As soon as I'm going to change something on the CLI interface, this script will be outdated.
-> It would be great if you could revert all changes in the actual rust code. I think its best if that file is located somewhere next to the actual code to make sure that people understand that this won't update itself.
| @@ -0,0 +1,191 @@ | |||
| module pueue_completions { | |||
There was a problem hiding this comment.
Could you also add a small comment, that this file is hand-written and needs to be updated whenever there're any changes to the cli interface :)?
|
Sorry to reply this so late :( I was busy removing my system on btrfs so I haven't seen it. |
I have written a completion file.
And write some code to fit it.